is there a way to create a ColorScheme with the full set of colors but not having to actually decide on all those colors? e.g. being able to say "i want a blue and green app" and have it figure out all the other colors from that for you?
Suggestion was deleted
Show more
Show less
Comment details cannot be verified
0 replies
New
Ian Hickson
Oct 28, 2021
Approver
why not just make them non-nullable with default values?
Suggestion was deleted
Show more
Show less
Comment details cannot be verified
Craig Labenz
Nov 4, 2021
Approver
It looks like this is because the default values for optional parameters are deduced from the values passed to required parameters.
Reply was deleted
Show more
Show less
Comment details cannot be verified
Ian Hickson
Nov 5, 2021
Approver
I'm not sure I follow.
Reply was deleted
Show more
Show less
Comment details cannot be verified
Craig Labenz
Nov 5, 2021
Approver
On second reading, this code isn't doing what I thought it was doing. I'd (mistakenly) concluded unpassed colors were filled in by referencing supplied colors - but that's not happening.
My brain must have been autocompleting with what's coming in the colorScheme generator.
Reply was deleted
Show more
Show less
Comment details cannot be verified
3 replies
New
dove cheng
May 14, 2024
Approver
Format: vertical alignment
Suggestion was deleted
Show more
Show less
Comment details cannot be verified
0 replies
New
dove cheng
May 14, 2024
Approver
Format: vertical alignment
Suggestion was deleted
Show more
Show less
Comment details cannot be verified
0 replies
New
Tim Sneath
Oct 29, 2021
Approver
What about non-Google usage? How much churn is this likely to create for our external developers?
Suggestion was deleted
Show more
Show less
Comment details cannot be verified
0 replies
New
Pierre Louis Guidez
Oct 26, 2021
Approver
I worry that this may produce flat color schemes, which may not satisfy a11y, but I'm not sure. Have we asked someone from design about this?
Suggestion was deleted
Show more
Show less
Comment details cannot be verified
Craig Labenz
Nov 4, 2021
Approver
Good point. I expect the complete colorScheme generator will probably be what solves this issue.
Reply was deleted
Show more
Show less
Comment details cannot be verified
1 reply
New
Rami Abou Ghanem
Oct 25, 2021
Approver
I think the fallback here would have to be secondary right? or is it that since tertiary falls back to secondary this would just follow that chain
Suggestion was deleted
Show more
Show less
Comment details cannot be verified
Darren Austin
Oct 25, 2021
Approver
It is just following the chain. My thinking was that if the user did supply a tertiary color, but not a tertiaryContainer, it should fall back to the tertiary they gave us instead of the secondary. If they supply neither, then it will fallback to the secondary color.
Reply was deleted
Show more
Show less
Comment details cannot be verified
1 reply
New
Ian Hickson
Oct 28, 2021
Approver
i don't think this scales (imagine what the API looks like after 15 of these migrations). What's wrong with changing the default colors?
Suggestion was deleted
Show more
Show less
Comment details cannot be verified
Craig Labenz
Nov 4, 2021
Approver
I think I'm coming down on this side, as well; as long as we don't bump into any invalid const type of issues while implementing the optional parameter juggling.
Reply was deleted
Show more
Show less
Comment details cannot be verified
1 reply
New
Rami Abou Ghanem
Sep 23, 2021
Approver
Yeah I think this is best (perhaps even rename the existing light/dark as lightM2/darkM2 and use flutter fix to update developers)
Suggestion was deleted
Show more
Show less
Comment details cannot be verified
Pierre Louis Guidez
Oct 26, 2021
Approver
I think so too. Wonder how this interacts with the idea of fallback. Is an m3 color scheme created with these constructors then: m3 baseline + provided nullable properties + fallbacks for non-provided nullable properties?
Reply was deleted
Show more
Show less
Comment details cannot be verified
1 reply
New
Craig Labenz
Nov 4, 2021
Approver
Thinking wildly here - given that we are aiming for a sort of autocompleting colorScheme, we might actually lean further into optional parameters.
Suggestion was deleted
Show more
Show less
Comment details cannot be verified
0 replies
New
Craig Labenz
Nov 4, 2021
Approver
But for this gotcha, I would probably prefer this option.
Suggestion was deleted
Show more
Show less
Comment details cannot be verified
0 replies
New
Will Larche
Sep 27, 2021
Approver
Agreed that you should also aim for a plan for future iterations.
Suggestion was deleted
Show more
Show less
Comment details cannot be verified
0 replies
New
You're suggesting
Gemini created these notes. They can contain errors so should be double-checked. How Gemini takes notes
Drag image to reposition
11
10
9
8
7
6
5
4
3
2
1
1
2
3
4
5
6
7
8
9
10
Outline
Outline
Document tabs
ColorScheme for Material 3
13
Headings you add to the document will appear here.
SUMMARY
OBJECTIVE
BACKGROUND
OVERVIEW
DETAILED DESIGN/DISCUSSION
Add new color properties to ColorScheme
Deprecate unused colors
Fallback defaults
Add new opt-in flag to ThemeData
OPEN QUESTIONS
OPTIONS CONSIDERED
Option 1 - Add new fields to existing ColorScheme class
Option 2 - Subclass ColorScheme
Option 3 - Provide a new standalone ColorSchemeMaterial3